New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to use unicode in balance tables #528
Conversation
Nice! tests/balance/pretty.test could be a good place. hledger/doc/balance.m4.md is the place to document the new flag. This will be great for bs/is/cf as well, rendered by Hledger/Cli/BalanceView.hs I think. |
I notice the top and left lines are double and the bottom line is single. Would it be better to flip these, so the double line emphasises the grand total ? |
Alright, tests & docs added and I also added support for this option in |
I don’t think so. The bottom line separates the totals from the individual values while the top line separates titles from the individual values. IMHO totals and individual values are more closely related (e.g. they are both numbers) than the titles and the values. |
In accounting reports I think it's traditional to use a thick/double line below columns of numbers, highlighting the grand totals. What do others think ? |
(NB this visual difference in line weights is more or less visible depending on the font, for anyone wondering..) |
Thanks! |
fixes #522
Currently this is just enabled for the balance report but I think that’s also the primary user of tables. It also needs some tests but I haven’t yet figured out where to add them. I’ll try to get to that in the next few days.